Fixed bug where, if no boardgames where missing from plays, data_connection still wanted to ask BGG for empty list

This commit is contained in:
Yarne Coppens 2024-09-07 16:08:41 +02:00
parent b30ead8ac9
commit f73accbacc

View file

@ -121,8 +121,9 @@ def get_plays(session: Session) -> list[play_classes.Play]:
played_boardgame_ids = list(filter(lambda x: x != None, played_boardgame_ids)) played_boardgame_ids = list(filter(lambda x: x != None, played_boardgame_ids))
boardgames_in_db, boardgame_ids_missing = db_connection.get_multiple_boardgames(session, boardgame_ids=played_boardgame_ids) boardgames_in_db, boardgame_ids_missing = db_connection.get_multiple_boardgames(session, boardgame_ids=played_boardgame_ids)
missing_boardgames = bgg_connection.get_multiple_boardgames(boardgame_ids_missing) if len(boardgame_ids_missing) != 0:
db_connection.upsert_multiple_boardgames(session, missing_boardgames) missing_boardgames = bgg_connection.get_multiple_boardgames(boardgame_ids_missing)
db_connection.upsert_multiple_boardgames(session, missing_boardgames)
assert len(list(filter(lambda x: x == None, played_boardgame_ids))) == 0, plays_from_db assert len(list(filter(lambda x: x == None, played_boardgame_ids))) == 0, plays_from_db