From 22a1227ee2d0d7d53a3d13bb4e889a071ef337b7 Mon Sep 17 00:00:00 2001
From: Yarninator <gitkraken@yarnecoppens.com>
Date: Mon, 5 Aug 2024 13:48:47 +0200
Subject: [PATCH] Validators now accept file content as string

---
 shop_validators/image_validator.py | 13 ++++++++-----
 src/main.py                        |  4 ++--
 validators/__init__.py             |  0
 validators/image_validator.py      | 23 -----------------------
 4 files changed, 10 insertions(+), 30 deletions(-)
 delete mode 100644 validators/__init__.py
 delete mode 100644 validators/image_validator.py

diff --git a/shop_validators/image_validator.py b/shop_validators/image_validator.py
index c50c9a1..c1bed98 100644
--- a/shop_validators/image_validator.py
+++ b/shop_validators/image_validator.py
@@ -1,7 +1,7 @@
 import re
 from PIL import Image
 
-def is_valid_image(file_name):
+def is_valid_image(file_name: str = None, file_content: str = None):
     try:
         with Image.open(file_name) as img:
             img.verify()
@@ -10,13 +10,16 @@ def is_valid_image(file_name):
         return False
 
 
-def is_valid_svg(file_name):
+def is_valid_svg(file_name: str = None, file_content: str = None):
+
     SVG_R = r'(?:<\?xml\b[^>]*>[^<]*)?(?:<!--.*?-->[^<]*)*(?:<svg|<!DOCTYPE svg)\b'
     SVG_RE = re.compile(SVG_R, re.DOTALL)
 
-    file_object = open(file_name, 'r')
-
-    file_contents = file_object.read()
+    if file_name != None:
+        file_object = open(file_name, 'r')
+        file_contents = file_object.read()
+    else:
+        file_contents = file_content
 
     is_svg = SVG_RE.match(file_contents) is not None
 
diff --git a/src/main.py b/src/main.py
index 1c295ba..61230f6 100644
--- a/src/main.py
+++ b/src/main.py
@@ -5,7 +5,7 @@ import os
 
 from src.classes import product_classes
 from src.config import definitions
-from validators import image_validator
+from shop_validators import image_validator
 from src import data_connection
 
 app = FastAPI()
@@ -39,6 +39,6 @@ def get_single_product(barcode: int):
 def get_icon(icon_filename: str):
     full_filepath = os.path.join(definitions.ICONS_PATH, icon_filename) + ".svg"
     assert os.path.exists(full_filepath), f"File {full_filepath} not found"
-    assert image_validator.is_valid_svg(full_filepath), f"File {full_filepath} is not a valid image"
+    assert image_validator.is_valid_svg(file_name=full_filepath), f"File {full_filepath} is not a valid image"
 
     return full_filepath
\ No newline at end of file
diff --git a/validators/__init__.py b/validators/__init__.py
deleted file mode 100644
index e69de29..0000000
diff --git a/validators/image_validator.py b/validators/image_validator.py
deleted file mode 100644
index c50c9a1..0000000
--- a/validators/image_validator.py
+++ /dev/null
@@ -1,23 +0,0 @@
-import re
-from PIL import Image
-
-def is_valid_image(file_name):
-    try:
-        with Image.open(file_name) as img:
-            img.verify()
-            return True
-    except (IOError, SyntaxError):
-        return False
-
-
-def is_valid_svg(file_name):
-    SVG_R = r'(?:<\?xml\b[^>]*>[^<]*)?(?:<!--.*?-->[^<]*)*(?:<svg|<!DOCTYPE svg)\b'
-    SVG_RE = re.compile(SVG_R, re.DOTALL)
-
-    file_object = open(file_name, 'r')
-
-    file_contents = file_object.read()
-
-    is_svg = SVG_RE.match(file_contents) is not None
-
-    return is_svg
\ No newline at end of file